Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v23.1.x] archival: don't instantiate merger on read replicas #9757

Merged

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #9685

Read replicas should perform no mutations on storage state. We
previously instantiated a segment merger and registered housekeeping
jobs for them.

This adds safeguards at a few levels to avoid this happening:
- returning early on read replicas instead of constructing a segment
  merger
- an assert in the constructor of the segment merger
- explicitly not registering housekeeping jobs on read replicas

(cherry picked from commit f4737f5)
@vbotbuildovich vbotbuildovich added this to the v23.1.x-next milestone Mar 31, 2023
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Mar 31, 2023
@andrwng andrwng marked this pull request as ready for review March 31, 2023 07:33
@BenPope
Copy link
Member

BenPope commented Apr 4, 2023

Ping

Copy link
Contributor

@andrwng andrwng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean backport

@andrwng andrwng merged commit 0a6ec08 into redpanda-data:v23.1.x Apr 4, 2023
@BenPope BenPope modified the milestones: v23.1.x-next, v23.1.7 Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants